[asterisk-bugs] [Asterisk 0016416]: [patch] Portability tweaks to contrib/scripts/safe_asterisk

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16416 
====================================================================== 
Reported By:                bklang
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16416
Category:                   Core/Portability
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-510 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 233774 
Request Review:              
====================================================================== 
Date Submitted:             2009-12-08 17:03 CST
Last Modified:              2010-01-06 17:11 CST
====================================================================== 
Summary:                    [patch] Portability tweaks to
contrib/scripts/safe_asterisk
Description: 
The attached patch addresses several minor issues that have to do with
improving the script's operation on non-Linux platforms:

1) Use mail instead of mailx (the latter supports specifying the subject
with -s)
2) Change several test cases to work with old versions of test
3) Change the invocation of the date(1) command to work with non-GNU
versions
4) Fix some minor bugs (such as the way id(1) is called and the order of
shell output redirects)
5) Improve the error message to be more helpful when/if Asterisk crashes.

There may be other portability issues, but this script has been tested on
OSX, Linux and OpenSolaris and works on those platforms.
====================================================================== 

---------------------------------------------------------------------- 
 (0116175) tilghman (administrator) - 2010-01-06 17:11
 https://issues.asterisk.org/view.php?id=16416#c116175 
---------------------------------------------------------------------- 
I have modified your patch quite a bit, because you've made some errors in
terms of making the script more cross-platform-aware.

1) You changed defaults, which is not permitted, especially in the middle
of a release cycle.
2) You changed from using the test utility to using the '[' shell builtin.
 This is less portable, not more portable.
3) Quotes around strings in test conditions allows values that contain
special characters to avoid being interpreted by the shell, thus the quotes
are needed for better portability. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-06 17:11 tilghman       Note Added: 0116175                          
======================================================================