[asterisk-bugs] [Asterisk 0016289]: [patch] core show function CDR reports wrong disposition values

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16289 
====================================================================== 
Reported By:                wdoekes
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   16289
Category:                   Functions/func_cdr
Reproducibility:            always
Severity:                   text
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-592 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-11-20 04:40 CST
Last Modified:              2010-01-06 15:48 CST
====================================================================== 
Summary:                    [patch] core show function CDR reports wrong
disposition values
Description: 
When running:

exten => s,1,Answer()
exten => s,n,NoOp(exten => _X.,n,NoOp(QUEUE_ANS: ${CDR(disposition)} /
${CDR(disposition,u)})

I get:

voip-test*CLI> 
<...snip...>
    -- Executing [s at pi_incoming_queue:2] NoOp("SIP/1.2.3.4-0241c1e0",
"QUEUE_ANS: ANSWERED / 8") in new stack
<...snip...>


When checking the function description, I get:

voip-test*CLI> core show function CDR
<...snip...>
   raw values for disposition:
       1 = NO ANSWER
       2 = BUSY
       3 = FAILED
       4 = ANSWERED
<...snip...>


This means that the raw disposition values in the documentation are wrong,
right?

According to svn blame it has always been like this in
include/asterisk/cdr.h:
#define AST_CDR_FAILED                          (1 << 0)
#define AST_CDR_BUSY                            (1 << 1)
#define AST_CDR_NOANSWER                        (1 << 2)
#define AST_CDR_ANSWERED                        (1 << 3)


Patch for 1.4:

<inline patch removed by lmadsen>

Patch for 1.6-svn:

<inline patch removed by lmadsen>



Regards,
Walter Doekes
OSSO B.V.
====================================================================== 

---------------------------------------------------------------------- 
 (0116165) svnbot (reporter) - 2010-01-06 15:48
 https://issues.asterisk.org/view.php?id=16289#c116165 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 238232

_U  branches/1.6.0/
U   branches/1.6.0/funcs/func_cdr.c

------------------------------------------------------------------------
r238232 | tilghman | 2010-01-06 15:48:32 -0600 (Wed, 06 Jan 2010) | 18
lines

Merged revisions 238231 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r238231 | tilghman | 2010-01-06 15:45:17 -0600 (Wed, 06 Jan 2010) | 11
lines
  
  Merged revisions 238230 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r238230 | tilghman | 2010-01-06 15:41:55 -0600 (Wed, 06 Jan 2010) | 4
lines
    
    Revise documentation on disposition values to the actual values used.
    (closes issue https://issues.asterisk.org/view.php?id=16289)
     Reported by: wdoekes
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=238232 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-06 15:48 svnbot         Checkin                                      
2010-01-06 15:48 svnbot         Note Added: 0116165                          
======================================================================