[asterisk-bugs] [Asterisk 0015224]: [patch] mp3 playback not working via AGI "STREAM FILE", but "EXEC PLAYBACK" works

[Asterisk Bug Tracker]

The following issue has been ASSIGNED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15224 
====================================================================== 
Reported By:                rbd
Assigned To:                seanbright
====================================================================== 
Project:                    Asterisk
Issue ID:                   15224
Category:                   Addons/format_mp3
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.24 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-05-29 12:49 CDT
Last Modified:              2010-01-06 09:27 CST
====================================================================== 
Summary:                    [patch] mp3 playback not working via AGI "STREAM
FILE", but "EXEC PLAYBACK" works
Description: 
-Ubuntu 8.10 x64
-Using Asterisk 1.4.24 (compiled from source), Addons 1.4.7

Trying to play an MP3 file via FastAGI "STREAM FILE" and/or "GET DATA"
commands fails, with the command returning immediately (log attached). We
have tried two different types of mp3 files:
-16-bit, 44.100kHz, CBR, 128kbit
(http://asterisk.gnuinter.net/files/digium/asterisk-ng/sounds/fpm-calm-river.mp3,
from the standard asterisk-addons distribution)
-16-bit, 11.025kHZ, CBR, 32kbit

Playing either mp3 with the Playback() callflow command (from
extensions.conf) works fine. It just seems that things are broken with
AGI.

This is a problem for us because EXEC PLAYBACK can't take DTMF. We need to
process DTMF like STREAM DATA allows for.

The AGI server script we are using is attached.

Note that in the log snippets you will see mention of voiceglue/phoneglue.
This is because we are working the voiceglue folks to get mp3 playback
working with it, and saw this bug. Note that in this testing here, we have
totally removed voiceglue out of the picture. This is just plain old
asterisk playing a plain old MP3 file.
====================================================================== 

---------------------------------------------------------------------- 
 (0116125) svnbot (reporter) - 2010-01-06 09:27
 https://issues.asterisk.org/view.php?id=15224#c116125 
---------------------------------------------------------------------- 
Repository: asterisk-addons
Revision: 1083

U   branches/1.4/formats/format_mp3.c

------------------------------------------------------------------------
r1083 | seanbright | 2010-01-06 09:27:19 -0600 (Wed, 06 Jan 2010) | 16
lines

Fix reading samples from format_mp3 after ast_seekstream/ast_tellstream.

There is a bug when using ast_seekstream/ast_tellstream with format_mp3 in
that
the file read position is not reset before attempting to read samples.  So
when
we seek to determine the maximum size of the file (as in res_agi's STREAM
FILE)
we weren't then resetting the file pointer so that we could properly read
samples.  This patch addresses that (in a similar manner to format_wav.c).

(closes issue https://issues.asterisk.org/view.php?id=15224)
Reported by: rbd
Patches:
      20091230_addons_1.4_issue15224.diff uploaded by seanbright (license
71)
Tested by: rbd, seanbright

Review: https://reviewboard.asterisk.org/r/453

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1083 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-06 09:27 svnbot         Note Added: 0116125                          
2010-01-06 09:27 svnbot         Status                   ready for review =>
assigned
======================================================================