[asterisk-bugs] [Asterisk 0016168]: Hold Time report (reportholdtime) issue

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16168 
====================================================================== 
Reported By:                nickilo
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   16168
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.1.5 
JIRA:                       SWP-466 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-11-02 17:23 CST
Last Modified:              2010-01-05 17:09 CST
====================================================================== 
Summary:                    Hold Time report (reportholdtime) issue
Description: 
When reporting hold time, 

the number of second has to be modulo 60 otherwise the announce can be :
2 minutes 123 seconds instead of 2 minutes 3 seconds

Additionnally the file queue-minute does not exist.

I hope i'm clear enough.

I propose to do the following changes to /apps/app_queue.c :

at line 4187 : change holdtimesecs = abs((now - qe->start)); TO
holdtimesecs = abs((now - qe->start)%60);

at line 4190 : change play_file(peer, qe->parent->sound_minute); TO
play_file(peer, qe->parent->sound_minutes);


Thank You

====================================================================== 

---------------------------------------------------------------------- 
 (0116090) svnbot (reporter) - 2010-01-05 17:09
 https://issues.asterisk.org/view.php?id=16168#c116090 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 237921

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_queue.c

------------------------------------------------------------------------
r237921 | dvossel | 2010-01-05 17:09:25 -0600 (Tue, 05 Jan 2010) | 22
lines

Merged revisions 237920 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r237920 | dvossel | 2010-01-05 17:08:50 -0600 (Tue, 05 Jan 2010) | 16
lines
  
  fixes holdtime playback issue in app_queue
  
  When reporting hold time, the number of seconds should be mod 60.
  Otherwise audio playback could be something like "2 minutes 123 seconds"
  rather than "2 minutes 3 seconds".
  
  Also, the "minute" sound file is missing, so for the moment until
  that file can be created the "minutes" file is used instead.
  
  (closes issue https://issues.asterisk.org/view.php?id=16168)
  Reported by: nickilo
  Patches:
        patch-unified-trunk-rev-222176 uploaded by nickilo (license )
  Tested by: nickilo, wonderg
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=237921 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-05 17:09 svnbot         Checkin                                      
2010-01-05 17:09 svnbot         Note Added: 0116090                          
======================================================================