[asterisk-bugs] [Asterisk 0016533]: [patch] Realtime is broken, blank strings aren't valid any more

Asterisk Bug Tracker noreply at bugs.digium.com
Mon Jan 4 12:40:04 CST 2010


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16533 
====================================================================== 
Reported By:                sergee
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   16533
Category:                   Addons/res_config_mysql
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-616 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 237134 
Request Review:              
====================================================================== 
Date Submitted:             2010-01-02 16:03 CST
Last Modified:              2010-01-04 12:40 CST
====================================================================== 
Summary:                    [patch] Realtime is broken, blank strings aren't
valid any more
Description: 
For a few years i've used a blank strings for values that i didn't wish to
specify. Recent commit into asterisk-addons 1.6.0 (revision 1070) broke
everything. A lot of problems arise, since my blank values aren't blank
anymore. For example, former blank fields 'fromuser' and 'fromdomain'
become not blank with this patch, and i get an error: SIP/2.0 400 Bad
Request – ‘Malformed/Missing FROM: field’.
Because my From header looks like this: From: "1000" <sip: @
>tag=as3e28b5d2

This problem doesn't have a simple solution, if you wish to support two
different blank values (empty strings and NULL) you should implement that
in the asterisk first. Replacing either value with non-empty strings is a
very bad idea, because there will be a lot of problems in both cases.

For now i wish that change would be reverted. Thank you in advance!
====================================================================== 

---------------------------------------------------------------------- 
 (0115969) tilghman (administrator) - 2010-01-04 12:40
 https://issues.asterisk.org/view.php?id=16533#c115969 
---------------------------------------------------------------------- 
Well, the actual problem is that you're not using the NULL values in the
database to specify that you don't want the values.  While this worked for
you before, it wasn't exactly to specification, so it was open to change.

In realtime, if you want the default values for a column, you should
specify the value as NULL, not blank. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-04 12:40 tilghman       Note Added: 0115969                          
======================================================================




More information about the asterisk-bugs mailing list