[asterisk-bugs] [Asterisk 0016385]: [patch] app_queue segfaults if realtime field uniqueid is NULL

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16385 
====================================================================== 
Reported By:                haakon
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   16385
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
JIRA:                       SWP-482 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 232810 
Request Review:              
====================================================================== 
Date Submitted:             2009-12-03 10:47 CST
Last Modified:              2010-01-04 10:37 CST
====================================================================== 
Summary:                    [patch] app_queue segfaults if realtime field
uniqueid is NULL
Description: 
This patch fixes the issue by notifying the user about the error.

I think this might be the cause of another bug report:
  https://issues.asterisk.org/view.php?id=16037
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016037 Realtime Queue Crashes Asterisk
====================================================================== 

---------------------------------------------------------------------- 
 (0115923) dvossel (administrator) - 2010-01-04 10:37
 https://issues.asterisk.org/view.php?id=16385#c115923 
---------------------------------------------------------------------- 
Haakon, your code looks good, thanks for the contribution! I tweaked a few
things I noticed while reviewing it.  Just looking at the code, membername
does not need a check.  uniqueid will crash if it was NULL for some reason,
but a warning should also be present if it is a zero length string. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-04 10:37 dvossel        Note Added: 0115923                          
======================================================================