[asterisk-bugs] [Asterisk 0015654]: [patch] Missing new-message notification for urgent messages

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15654 
====================================================================== 
Reported By:                tomo1657
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   15654
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.1.2 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 210394 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-08-04 13:23 CDT
Last Modified:              2010-02-26 12:48 CST
====================================================================== 
Summary:                    [patch] Missing new-message notification for urgent
messages
Description: 
notify_new_message() is not called when urgent, new messages are left in a
mailbox using non-IMAP file system storage.

Urgent messages are moved to the "Urgent" folder so the following
condition to check INBOX for the new message (line 5312) is always false,
and notify_new_message() is never called.

  if (ast_fileexists(fn, NULL, NULL)) {

A workaround would be to add an exception for urgent messages:

  if (ast_fileexists(fn, NULL, NULL) && !ast_strlen_zero(flag) &&
!strcmp(flag, "Urgent"))

which I have attacked a patch of.  There are other ways to approach this,
though.  (Run notify_new_message() within the urgent message section or
checking for dfn location instead of fn)
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
parent of           0016448 Voicemail messages flagged as urgent do...
====================================================================== 

---------------------------------------------------------------------- 
 (0118615) svnbot (reporter) - 2010-02-26 12:48
 https://issues.asterisk.org/view.php?id=15654#c118615 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 249189

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_voicemail.c

------------------------------------------------------------------------
r249189 | tilghman | 2010-02-26 12:48:58 -0600 (Fri, 26 Feb 2010) | 24
lines

Merged revisions 249187 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r249187 | tilghman | 2010-02-26 12:41:57 -0600 (Fri, 26 Feb 2010) | 18
lines
  
  Cleanups to fix bugs in the VM count API functions.
  
  - Urgent voicemails were not attached, because the attachment code
looked in the wrong folder.
  - Urgent voicemails were sometimes counted twice when displaying the
count of new messages.
  - Backends were inconsistent as to which voicemails each API counted.
  
  (closes issue https://issues.asterisk.org/view.php?id=15654)
   Reported by: tomo1657
   Patches: 
         20100225__issue15654.diff.txt uploaded by tilghman (license 14)
   Tested by: tilghman
  
  (closes issue https://issues.asterisk.org/view.php?id=16448)
   Reported by: hevad
  
  Review: https://reviewboard.asterisk.org/r/525/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249189 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-26 12:48 svnbot         Checkin                                      
2010-02-26 12:48 svnbot         Note Added: 0118615                          
======================================================================