[asterisk-bugs] [Asterisk 0016557]: Asterisk produces malformed email files for voicemail

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16557 
====================================================================== 
Reported By:                jcovert
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16557
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.0.20 
JIRA:                       SWP-954 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-01-06 09:29 CST
Last Modified:              2010-02-24 10:20 CST
====================================================================== 
Summary:                    Asterisk produces malformed email files for
voicemail
Description: 
Asterisk is inserting an extra <cr> into the voicemail attachment.  This
causes some mail relays to fail to forward the SMTP message.

While the correct line termination in an SMTP message IS <cr><lf>, the
conversion from the Unix <lf> line terminator to <cr><lf> is handled by
sendmail.  When sendmail gets a file which (mostly) has just <lf>
terminators up until the attachment, it sees the <cr><lf> in the attachment
portion and converts that to <cr><cr><lf>.  This confuses some mail relays
down the road and prevents delivery.

This is a problem in all versions, and the fix is trivial:

At line 418 of the current head, there appears

#define eol "\r\n" 

this should just be "\n"

The resulting SMTP message will still have <cr><lf> once it has been
processed by the sendmail command.

"eol" is used ONLY in "ochar" which is used only in "base_encode".

====================================================================== 

---------------------------------------------------------------------- 
 (0118481) lmadsen (administrator) - 2010-02-24 10:20
 https://issues.asterisk.org/view.php?id=16557#c118481 
---------------------------------------------------------------------- 
Basically, checkout a vanilla copy of Asterisk from subversion:

svn co http://svn.asterisk.org/svn/asterisk/trunk

If it applies to multiple branches (1.4, 1.6.x, etc...) and the patch
needs to be changed to apply, also attach those patches (i.e. maybe the
functionality change needs to be different between versions, or one version
needs extra changes for IMAP and ODBC functionality, etc...)

Make the changes to the trunk and/or branches and then run:

svn diff > ~/__20100224-some-descriptive-patch-name.patch.txt

Then upload it to this issue and click the checkbox that says this is code
or documentation contribution.

If you have not already signed the electronic license (you'll see at link
at the top of the page in the title bar) do that first. If you have already
signed it, then upload away! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-24 10:20 lmadsen        Note Added: 0118481                          
======================================================================