[asterisk-bugs] [Asterisk 0016685]: [patch] Configured CFLAGS/LDFLAGS are used by main, but not by modules built out of tree

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16685 
====================================================================== 
Reported By:                pprindeville
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16685
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Target Version:             1.6.0.24
Asterisk Version:           SVN 
JIRA:                       SWP-789 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-01-24 22:09 CST
Last Modified:              2010-02-19 20:43 CST
====================================================================== 
Summary:                    [patch] Configured CFLAGS/LDFLAGS are used by main,
but not by modules built out of tree
Description: 
The patch supplied by Kevin in:

http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=214696

doesn't include Makefile.rules, so out-of-tree modules (which use
Makefile.moddir_rules which includes Makefile.rules) won't have properly
initialized values for _ASTCFLAGS and ASTLDFLAGS.

====================================================================== 

---------------------------------------------------------------------- 
 (0118305) pprindeville (reporter) - 2010-02-19 20:43
 https://issues.asterisk.org/view.php?id=16685#c118305 
---------------------------------------------------------------------- 
Anyway, regarding your question:

Sometimes it's just *useful* to build out of tree.

(1) you're making changes to Asterisk core functionality, but don't want
those changes spilling over into modules which should be free of
dependencies on those changes.

(2) you're building on a machine with limited resources, and don't want to
build against the source tree... just the required headers and libraries.

And I'm not asking for a review... I'm asking for a fix.  The way that
LDFLAGS and CFLAGS are used in various subdirectories is highly
inconsistent (and somewhat suspect).  This should probably be cleaned up.

Preferably by the person that made the changes in the first place, since
(a) he knows what end-goal he's trying to achieve better than anyone else
does, and (b) fixing this damage might remind him of other places where
he's incurred similar damage that hasn't yet been reported. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-19 20:43 pprindeville   Note Added: 0118305                          
======================================================================