[asterisk-bugs] [Asterisk 0016840]: [patch] Deadlock in chan_local when obtaining locks on local_pvt->lock

Asterisk Bug Tracker noreply at bugs.digium.com
Thu Feb 18 05:01:27 CST 2010


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16840 
====================================================================== 
Reported By:                bzing2
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16840
Category:                   Channels/chan_local
Reproducibility:            random
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.2.2 
JIRA:                       SWP-925 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-02-16 11:40 CST
Last Modified:              2010-02-18 05:01 CST
====================================================================== 
Summary:                    [patch] Deadlock in chan_local when obtaining locks
on local_pvt->lock
Description: 
Deadlock condition in chan_local when two brideged threads attempt to
obtain
locks to eachothers local_pvt structures in the opposite order.  All
processing of SIP traffic halts when an attempt is made to hangup the
call.

Thread A obtains a lock to its local_pvt->lock when in local_write.  When
in check_bridge a call is made to ast_bridged_channel, this in turn calls
local_bridgedchannel which attempts to obtain a lock on the bridged
channels
local_pvt->lock.

Thread B follows a similar path.  It holds its own lock, and during a call
to
ast_channel_masquerade again local_bridgedchannel is called.  This
attempts to
obtain a lock to the bridged channel.

At this point either side has deadlocked.  Then a user attempts to hangup
the
call and again local_bridgedchannel is called, and blocks while attempting
to
get the lock.  Unfortunalty sip netlock is held and everything grinds to a
halt.

====================================================================== 

---------------------------------------------------------------------- 
 (0118212) bzing2 (reporter) - 2010-02-18 05:01
 https://issues.asterisk.org/view.php?id=16840#c118212 
---------------------------------------------------------------------- 
Thanks for that!  Seems your thinking was aligned with mine, ie only do
this in one direction.  I have put my patch into production, which in
theory should achieve roughly the same result.  I will apply your patch to
my code base shortly; unfortunatly I have to wait for a maintance window to
deploy it, which in this case is a week Tuesday.  I will let you know the
results.  Thanks for your efforts. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-18 05:01 bzing2         Note Added: 0118212                          
======================================================================




More information about the asterisk-bugs mailing list