[asterisk-bugs] [Asterisk 0016815]: [patch] chan_sip does not decrease module refcount on deferred BYE

[Asterisk Bug Tracker]

The following issue is now READY FOR TESTING. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16815 
====================================================================== 
Reported By:                rain
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16815
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.2.2 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-02-11 14:35 CST
Last Modified:              2010-02-17 13:34 CST
====================================================================== 
Summary:                    [patch] chan_sip does not decrease module refcount
on deferred BYE
Description: 
When sip_hangup clears a channel with SIP_DEFER_BYE_ON_TRANSFER set, it
will return without calling ast_module_unref().  This causes the use
counter for chan_sip to increase over time, making it impossible to unload
the module without restarting Asterisk.

The attached patch calls ast_module_unref() immediately before returning
in the deferred BYE case.  I believe this is safe, because the SIP dialog
involved will still be freed when the containing AO2 object's refcount hits
0 as part of module_unload.

====================================================================== 

---------------------------------------------------------------------- 
 (0118171) lmadsen (administrator) - 2010-02-17 13:34
 https://issues.asterisk.org/view.php?id=16815#c118171 
---------------------------------------------------------------------- 
Thanks for the contribution! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-17 13:34 lmadsen        Note Added: 0118171                          
2010-02-17 13:34 lmadsen        Status                   new => ready for
testing
======================================================================