[asterisk-bugs] [Asterisk 0016852]: [patch] Some issues with New SDP handling code and T.38

[Asterisk Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16852 
====================================================================== 
Reported By:                cfc
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16852
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 247162 
Request Review:              
====================================================================== 
Date Submitted:             2010-02-17 08:36 CST
Last Modified:              2010-02-17 08:36 CST
====================================================================== 
Summary:                    [patch] Some issues with New SDP handling code and
T.38
Description: 
- Connection information defined at media level are not read. If SDP don't
define a (c=) at session level, process_sdp() fail with "Insufficient
information in SDP (c=)...". The patch add processing of (c=) defined at
media level for image too.

- As process_sdp() now use a dedicated "isin" sockaddr_in,
sin.sin_addr.s_addr stay null in case of T38 re-invite. This force to hold
the channel. If MusicOnHold is present, generator is setup on the channel.
This result in dropping all udptl frames... The patch add a check on isin
to avoid unwanted Hold state.

====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-17 08:36 cfc            New Issue                                    
2010-02-17 08:36 cfc            Asterisk Version          => SVN             
2010-02-17 08:36 cfc            Regression                => No              
2010-02-17 08:36 cfc            SVN Branch (only for SVN checkouts, not tarball
releases) =>  1.4            
2010-02-17 08:36 cfc            SVN Revision (number only!) => 247162          
======================================================================