[asterisk-bugs] [Asterisk 0016643]: [patch] Setting "timerb" on chan_sip.conf doesn't work at all, in [general] or peer

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16643 
====================================================================== 
Reported By:                nahuelgreco
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16643
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Target Version:             1.6.0.24
Asterisk Version:           SVN 
JIRA:                       SWP-756 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-01-18 18:45 CST
Last Modified:              2010-02-15 18:19 CST
====================================================================== 
Summary:                    [patch] Setting "timerb" on chan_sip.conf doesn't
work at all, in [general] or peer
Description: 
Asterisk 1.6.0.20, 1.6.1.12, 1.6.2.0, trunk rev 241145, all come with an
example of the "timerb" usage as a global parameter in sip.conf.sample, but
setting it doesn't work at all, so his documented usage is misleading.

If you change it in the [general] section, then chan_sip.c will do nothing
with that declaration. His global_timer_b variable is only assigned to
"timert1"*64, and there is no presence of "timerb" in the reload_config()
function for the [general] section.

If you instead set this timer for an specific peer, then is treated in the
build_peer() function, but the treatment seems to be incomplete. There are
two possible outcomings: the timer is not valid and the global one is used,
or the timer has a lower setting that the recommended and a warning is
printed... but there is no other usage of the retrieved "timerb" peer
config value, so is lost and never assigned to any variable.

So, doesn't matter how you use the "timerb" parameter in sip.conf, it has
no effects at all. 

====================================================================== 

---------------------------------------------------------------------- 
 (0118092) svnbot (reporter) - 2010-02-15 18:19
 https://issues.asterisk.org/view.php?id=16643#c118092 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 246724

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r246724 | tilghman | 2010-02-15 18:19:38 -0600 (Mon, 15 Feb 2010) | 8
lines

Allow Timer B to be set on the peer, and ensure SIP rules are followed (or
warn) in comparison to Timer T1.

(closes issue https://issues.asterisk.org/view.php?id=16643)
 Reported by: nahuelgreco
 Patches: 
       20100204__issue16643.diff.txt uploaded by tilghman (license 14)
 Tested by: oej

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=246724 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-15 18:19 svnbot         Checkin                                      
2010-02-15 18:19 svnbot         Note Added: 0118092                          
======================================================================