[asterisk-bugs] [Asterisk 0016707]: [patch] Caller name lost during call redirect

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16707 
====================================================================== 
Reported By:                Nick_Lewis
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   16707
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Target Version:             1.4.31
Asterisk Version:           SVN 
JIRA:                       SWP-810 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-01-26 10:08 CST
Last Modified:              2010-02-15 09:45 CST
====================================================================== 
Summary:                    [patch] Caller name lost during call redirect
Description: 
Unquoted display names are lost during call redirect. The function
read_to_parts does not use the get_calleridname function but tries to get
the display name directly. It fails to do this for unquoted display names
====================================================================== 

---------------------------------------------------------------------- 
 (0118075) svnbot (reporter) - 2010-02-15 09:45
 https://issues.asterisk.org/view.php?id=16707#c118075 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 246627

U   trunk/channels/chan_sip.c
U   trunk/channels/sip/include/reqresp_parser.h
U   trunk/channels/sip/include/sip_utils.h
U   trunk/channels/sip/reqresp_parser.c

------------------------------------------------------------------------
r246627 | dvossel | 2010-02-15 09:45:02 -0600 (Mon, 15 Feb 2010) | 22
lines

chan_sip parse code refactoring plus two new unit tests

Code Refactoring Changes
- read_to_parts() moved to reqresp_parser.c and has been renamed as
  get_name_and_number()
- get_in_brackets() moved to reqresp_parser.c
- find_closing_quotes() added to sip_utils.h
Logic Changes
- get_name_and_number() now uses parse_uri() and get_calleridname()
  for parsing. Before this change only names within quotes were
  found, when names not within quotes are possible.
New Unit Tests
-sip_get_name_and_number_test
-sip_get_in_brackets_test

(closes issue https://issues.asterisk.org/view.php?id=16707)
Reported by: Nick_Lewis
Patches:
      issue16706.diff uploaded by dvossel (license 671)

Review: https://reviewboard.asterisk.org/r/499/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=246627 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-15 09:45 svnbot         Note Added: 0118075                          
======================================================================