[asterisk-bugs] [Asterisk 0015932]: Make internal_timing on by default

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15932 
====================================================================== 
Reported By:                dimas
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15932
Category:                   Core/General
Reproducibility:            have not tried
Severity:                   tweak
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                       SWP-725 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-09-22 09:45 CDT
Last Modified:              2010-02-10 17:21 CST
====================================================================== 
Summary:                    Make internal_timing on by default
Description: 
Are there any reason to not have internal_timing on by default?

As I already wrote in https://issues.asterisk.org/view.php?id=15296, 
"I never understood why internal_timing is not YES by default. Everybody I
know turn it on as the first thing after Asterisk installation. And I see
lots of "i have bad audio" topics on forums where people eventually get
advice "turn internal timing on". From the other hand, I have not seen any
problem which is solved by turning that timing off.. "

Since Leif suggested me to fill an issue about the subject so here we
are...
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0005374 [patch] Asynchronous generation of outg...
parent of           0016285 Review of internal_timing code
====================================================================== 

---------------------------------------------------------------------- 
 (0117974) qwell (administrator) - 2010-02-10 17:21
 https://issues.asterisk.org/view.php?id=15932#c117974 
---------------------------------------------------------------------- 
I reviewed the code and did some testing..  I think I'm satisfied with the
results.

The way I see it, there are 2 ways to go about this.

1) Change Makefile to enable internal_timing in the sample asterisk.conf.
2) Enable it in code, and allow internal_timing=no to disable it. (small
Makefile mod to set the default commented out to be =no)

Either should be acceptable.

If you could provide a patch here that others could test, I think it could
go in fairly easily.


For trunk...I'm of the opinion that we just remove the option entirely. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-10 17:21 qwell          Note Added: 0117974                          
======================================================================