[asterisk-bugs] [Asterisk 0016689]: [patch] Crash in res_agi when trying to send application usage

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16689 
====================================================================== 
Reported By:                bklang
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16689
Category:                   Resources/res_agi
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.1.16
Asterisk Version:           SVN 
JIRA:                       SWP-793 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!): 242606 
Request Review:              
====================================================================== 
Date Submitted:             2010-01-24 23:55 CST
Last Modified:              2010-02-10 10:01 CST
====================================================================== 
Summary:                    [patch] Crash in res_agi when trying to send
application usage
Description: 
I believe this bug is related to the fact that my console documentation is
not loaded (see bug https://issues.asterisk.org/view.php?id=16688).

When sending an invalid AGI command to Asterisk, the system attempts to
return usage information for the requested application.  Based on my
reading of the crash information from gdb, because the console
documentation is not loaded, the usage information is not available
(c->usage is uninitialized).  On my system, this causes a segfault when it
is referenced.

I have attached output from gdb (bt; bt full; thread apply all bt full).

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016688 Console documentation not loaded from XML
====================================================================== 

---------------------------------------------------------------------- 
 (0117945) svnbot (reporter) - 2010-02-10 10:01
 https://issues.asterisk.org/view.php?id=16689#c117945 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 246030

U   trunk/configure
U   trunk/configure.ac
U   trunk/include/asterisk/autoconfig.h.in
U   trunk/res/res_agi.c

------------------------------------------------------------------------
r246030 | tilghman | 2010-02-10 10:01:28 -0600 (Wed, 10 Feb 2010) | 12
lines

Solaris doesn't like outputting a NULL to a %s in format strings.

Detect all platforms that don't like that, either, and ensure that when
documentation is
missing, we pass a non-NULL pointer when outputting the corresponding
documentation.

(closes issue https://issues.asterisk.org/view.php?id=16689)
 Reported by: bklang
 Patches: 
       20100209__issue16689__with_tests.diff.txt uploaded by tilghman
(license 14)
 
Review: https://reviewboard.asterisk.org/r/497/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=246030 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-10 10:01 svnbot         Checkin                                      
2010-02-10 10:01 svnbot         Note Added: 0117945                          
======================================================================