[asterisk-bugs] [Asterisk 0016766]: [patch] T.38 negotiation fails with Patton SN2400

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16766 
====================================================================== 
Reported By:                raivisr
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   16766
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Target Version:             1.6.0.24
Asterisk Version:           SVN 
JIRA:                       SWP-868 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 244639 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-02-03 16:00 CST
Last Modified:              2010-02-09 11:49 CST
====================================================================== 
Summary:                    [patch] T.38 negotiation fails with Patton SN2400
Description: 
Patton SN2400 refuses to negotiate T.38 session because of extra newline in
SDP.

[Feb  3 22:31:46] DEBUG[31017] chan_sip.c:    Body  5 [ 22]: m=image 4326
udptl t38
[Feb  3 22:31:46] DEBUG[31017] chan_sip.c:    Body  6 [  0]: 
[Feb  3 22:31:46] DEBUG[31017] chan_sip.c:    Body  7 [ 17]:
a=T38FaxVersion:0

proposed fix:
--- asterisk.orig/channels/chan_sip.c	2010-02-03 23:52:03.000000000 +0200
+++ asterisk/channels/chan_sip.c	2010-02-03 23:58:41.000000000 +0200
@@ -9191,8 +9191,6 @@ static enum sip_result add_sdp(struct si
  		ast_str_append(&m_video, 0, "\r\n");
  	if (needtext)
  		ast_str_append(&m_text, 0, "\r\n");
-	if (add_t38)
-		ast_str_append(&m_modem, 0, "\r\n");
 
  	len = strlen(version) + strlen(subject) + strlen(owner) +
 		strlen(connection) + strlen(session_time);

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012437 Asterisk negotiates only T.38 when answ...
====================================================================== 

---------------------------------------------------------------------- 
 (0117896) svnbot (reporter) - 2010-02-09 11:49
 https://issues.asterisk.org/view.php?id=16766#c117896 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 245728

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r245728 | mnicholson | 2010-02-09 11:43:41 -0600 (Tue, 09 Feb 2010) | 15
lines

Merged revisions 245727 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r245727 | mnicholson | 2010-02-09 11:40:04 -0600 (Tue, 09 Feb 2010) | 2
lines
  
  This commit removes an extra newline in T.38 generated SDP packets. This
bug was caused by the fix introduced in r243860.

  (closes issue https://issues.asterisk.org/view.php?id=16766)
  Reported by: raivisr
  Patches:
        t38-sdp-newline-fix1.diff uploaded by mnicholson (license 96)
  Tested by: raivisr
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=245728 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-09 11:49 svnbot         Checkin                                      
2010-02-09 11:49 svnbot         Note Added: 0117896                          
======================================================================