[asterisk-bugs] [Asterisk 0016596]: [patch] LD (llinker) options not used by main/ and channels/ builds

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16596 
====================================================================== 
Reported By:                pprindeville
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   16596
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.2.0 
JIRA:                       SWP-720 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-01-13 13:39 CST
Last Modified:              2010-02-08 16:46 CST
====================================================================== 
Summary:                    [patch] LD (llinker) options not used by main/ and
channels/ builds
Description: 
The top-level makefile passes $(ASTLDFLAGS) which is user-specified and
$(_ASTLDFLAGS) which is system-generated to the subdirs main/ and channels/
when they are built.  Unfortunately, the makefiles in these directories
don't use them.

If building in an environment that requires additional flags for
correctness (e.g. when building against multiple versions of the same
libraries), this may cause linkage against the wrong libraries (in this
case, the system default libraries would be used) which would result in
incorrect binaries being built.

Since the binaries are somewhat likely to succeed (with the default
libraries), this would result in incorrect test results when doing software
validation (since the desired libraries would not have been used, and hence
not tested).

====================================================================== 

---------------------------------------------------------------------- 
 (0117867) svnbot (reporter) - 2010-02-08 16:46
 https://issues.asterisk.org/view.php?id=16596#c117867 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 245580

_U  branches/1.6.1/
U   branches/1.6.1/channels/Makefile
U   branches/1.6.1/main/Makefile

------------------------------------------------------------------------
r245580 | tilghman | 2010-02-08 16:46:36 -0600 (Mon, 08 Feb 2010) | 19
lines

Merged revisions 245578 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r245578 | tilghman | 2010-02-08 16:31:40 -0600 (Mon, 08 Feb 2010) | 12
lines
  
  Actually use _ASTLDFLAGS in the main/ and channels/ Makefiles.
  
  They were previously passed correctly, but they simply weren't used. 
This
  caused issues with various platforms whose builds needed to pass special
  linker flags via the configure script.
  
  (closes issue https://issues.asterisk.org/view.php?id=16596)
   Reported by: pprindeville
   Patches: 
         asterisk-1.6-astldflags.patch uploaded by pprindeville (license
347)
   Tested by: tilghman
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=245580 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-08 16:46 svnbot         Checkin                                      
2010-02-08 16:46 svnbot         Note Added: 0117867                          
======================================================================