[asterisk-bugs] [Asterisk 0016285]: Review of internal_timing code

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16285 
====================================================================== 
Reported By:                lmadsen
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16285
Category:                   Core/General
Reproducibility:            N/A
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                       SWP-726 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-19 09:23 CST
Last Modified:              2010-02-05 14:22 CST
====================================================================== 
Summary:                    Review of internal_timing code
Description: 
Per Russell's comments on the mailing list in reference to a suggestion to
make 'internal_timing' on by default:

"I'm fine with this in general (even in 1.4).  However, someone just 
needs to do an audit of the related code to make sure that nothing bad 
will happen if this is on and DAHDI is not available.  That also 
includes scary error messages telling someone the world is broken when 
it's not really true."
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
child of            0015932 Make internal_timing on by default
====================================================================== 

---------------------------------------------------------------------- 
 (0117802) qwell (administrator) - 2010-02-05 14:22
 https://issues.asterisk.org/view.php?id=16285#c117802 
---------------------------------------------------------------------- 
Looking at the patch and the bug report that added this feature, I've
concluded that it should be safe to proceed.  In fact, I would argue that
we should just *remove* the option entirely (in branches that use
res_timing_, at least).

The patch is incredibly small.  The option was apparently an afterthought
which seemed like a good idea in case it broke things (it hasn't).

I'd like to do a bit of testing (which should perhaps by in the parent
issue) before we do anything though. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-05 14:22 qwell          Note Added: 0117802                          
======================================================================