[asterisk-bugs] [Asterisk 0016686]: [patch] app_dial does not respect GOSUB_RESULT

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16686 
====================================================================== 
Reported By:                bklang
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16686
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                       SWP-790 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!): 242606 
Request Review:              
====================================================================== 
Date Submitted:             2010-01-24 23:26 CST
Last Modified:              2010-02-02 14:32 CST
====================================================================== 
Summary:                    [patch] app_dial does not respect GOSUB_RESULT
Description: 
When using the U() option with app_dial, the GOSUB_RESULT flag as set in
the called context is not respected by app_dial.  This leads to calls not
being hung up as they should per the documentation.

The problem is that the variable GOSUB_RESULT is checked, but the flag
intending to hang up the called channel (peer) is never consulted after the
Gosub handling is complete.  This patch fixes the behavior so the channel
is properly hung up.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016687 [patch] app_dial gosub does not pass ba...
====================================================================== 

---------------------------------------------------------------------- 
 (0117557) svnbot (reporter) - 2010-02-02 14:32
 https://issues.asterisk.org/view.php?id=16686#c117557 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 244393

U   trunk/CHANGES
U   trunk/apps/app_dial.c

------------------------------------------------------------------------
r244393 | tilghman | 2010-02-02 14:32:30 -0600 (Tue, 02 Feb 2010) | 18
lines

Properly respect GOSUB_RESULT as to what to do with the master channel.

Previously, we would parse GOSUB_RESULT, but not actually do anything with
it.
Also, allow GOSUB_RETVAL to be inherited back across a peer/master
channel.

(closes issue https://issues.asterisk.org/view.php?id=16687)
 Reported by: bklang
 Patches: 
       app_dial-preserve-gosub_retval.patch uploaded by bklang (license
919)
       (with modifications)

(closes issue https://issues.asterisk.org/view.php?id=16686)
 Reported by: bklang
 Patches: 
       app_dial-respect-gosub_result.patch uploaded by bklang (license
919)
       (with modifications)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=244393 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-02 14:32 svnbot         Checkin                                      
2010-02-02 14:32 svnbot         Note Added: 0117557                          
======================================================================