[asterisk-bugs] [Asterisk 0016687]: [patch] app_dial gosub does not pass back GOSUB_RETVAL

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16687 
====================================================================== 
Reported By:                bklang
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16687
Category:                   Applications/app_dial
Reproducibility:            N/A
Severity:                   tweak
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-791 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!): 242606 
Request Review:              
====================================================================== 
Date Submitted:             2010-01-24 23:29 CST
Last Modified:              2010-02-02 14:32 CST
====================================================================== 
Summary:                    [patch] app_dial gosub does not pass back
GOSUB_RETVAL
Description: 
When calling a Gosub routine (Dial with U() option) the GOSUB_RETVAL
variable is not propagated back to the calling channel.  This makes it
effectively impossible to alter the behavior of the dialplan by having the
Gosub routine set a value with the Result application.

This patch alters app_dial to check for the GOSUB_RETVAL channel variable
on the called channel (peer) and, if set, set it on the calling channel
(chan).
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016686 [patch] app_dial does not respect GOSUB...
====================================================================== 

---------------------------------------------------------------------- 
 (0117556) svnbot (reporter) - 2010-02-02 14:32
 https://issues.asterisk.org/view.php?id=16687#c117556 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 244393

U   trunk/CHANGES
U   trunk/apps/app_dial.c

------------------------------------------------------------------------
r244393 | tilghman | 2010-02-02 14:32:30 -0600 (Tue, 02 Feb 2010) | 18
lines

Properly respect GOSUB_RESULT as to what to do with the master channel.

Previously, we would parse GOSUB_RESULT, but not actually do anything with
it.
Also, allow GOSUB_RETVAL to be inherited back across a peer/master
channel.

(closes issue https://issues.asterisk.org/view.php?id=16687)
 Reported by: bklang
 Patches: 
       app_dial-preserve-gosub_retval.patch uploaded by bklang (license
919)
       (with modifications)

(closes issue https://issues.asterisk.org/view.php?id=16686)
 Reported by: bklang
 Patches: 
       app_dial-respect-gosub_result.patch uploaded by bklang (license
919)
       (with modifications)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=244393 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-02 14:32 svnbot         Checkin                                      
2010-02-02 14:32 svnbot         Note Added: 0117556                          
======================================================================