[asterisk-bugs] [Asterisk 0016740]: [patch] New mute feature for MixMonitor

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16740 
====================================================================== 
Reported By:                jmls
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16740
Category:                   PBX/NewFeature
Reproducibility:            N/A
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 244062 
Request Review:              
====================================================================== 
Date Submitted:             2010-01-31 03:28 CST
Last Modified:              2010-02-01 04:10 CST
====================================================================== 
Summary:                    [patch] New mute feature for MixMonitor
Description: 
for PCI-DSS compliance we are not allowed to record a credit card number is
a MixMonitor file. However, we must record all conversations ....

I have added a new feature to audiohooks so that you can mute either read
/ write or both types of frames - this allows for MixMonitor to mute either
side of the conversation without affecting the conversation itself.

MixMonitor now has two manager commands

1) manager show command MuteMixMonitor
Action: MuteMixMonitor
Synopsis: Mute a channel in MixMonitor
Privilege: <none>
Description: Mutes a Mixmonitor Channel.
Variables:
  Channel: Channel to mute.
  Direction: Which part to mute. read|write|both (from channel|to
channel|both channels).

2)  manager show command unMuteMixMonitor
Action: unMuteMixMonitor
Synopsis: unMute a channel in MixMonitor
Privilege: <none>
Description: unMutes a Mixmonitor Channel.
Variables:
  Channel: Channel to unmute.
  Direction: Which part to unmute. read|write|both (from channel|to
channel|both channels).



====================================================================== 

---------------------------------------------------------------------- 
 (0117422) jmls (manager) - 2010-02-01 04:10
 https://issues.asterisk.org/view.php?id=16740#c117422 
---------------------------------------------------------------------- 
Thanks snuffy. Updated the documentation, but looking at the "1" vs "0" I
notice that a little further up is this code snippet:

 if (ast_strlen_zero(args.filename)) {
                ast_log(LOG_WARNING, "MixMonitor requires an argument
(filename)\n");
                return -1;
        }

So, should I be returning -1, or 1 if there is an error ? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-01 04:10 jmls           Note Added: 0117422                          
======================================================================