[asterisk-bugs] [Asterisk 0016732]: [patch] Add AMI support for device states

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16732 
====================================================================== 
Reported By:                haakon
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16732
Category:                   Functions/func_devstate
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-826 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 244040 
Request Review:              
====================================================================== 
Date Submitted:             2010-01-29 09:28 CST
Last Modified:              2010-02-01 01:43 CST
====================================================================== 
Summary:                    [patch] Add AMI support for device states
Description: 
main/devicestate.c says Asterisk Manager Interface (AMI) gets DeviceState
events, but this is not true.

This patch adds a "DeviceStateChanged" event to AMI. And also introduces
AMI commands DeviceStateSet and DeviceStateGet to controll device states
from AMI, if func_devicestate is compiled in.
====================================================================== 

---------------------------------------------------------------------- 
 (0117416) oej (manager) - 2010-02-01 01:43
 https://issues.asterisk.org/view.php?id=16732#c117416 
---------------------------------------------------------------------- 
Hi!
Good patch, thanks!

When there is only one possible response, you should send the response in
the response, not in an additional event.

Manager always subscribes to all state changes - is it really needed to
have one more? If so, it has to be configurable since we will then have
three events for every state change in SIP devices - on from the chan_sip
file, one from manager extension state and one for the device state change.
I'm not sure it should be in the CALL category either. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-02-01 01:43 oej            Note Added: 0117416                          
======================================================================