[asterisk-bugs] [Asterisk 0018546]: WARNING message for each IAX peer with a qualifyfreqnotok setting

[Asterisk Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18546 
====================================================================== 
Reported By:                jcovert
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18546
Category:                   Channels/chan_iax2
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     new
Asterisk Version:           1.8.1.1 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-12-28 17:38 CST
Last Modified:              2010-12-28 17:38 CST
====================================================================== 
Summary:                    WARNING message for each IAX peer with a
qualifyfreqnotok setting
Description: 
Spurious warnings appear as follows:

[Dec 28 17:03:21] WARNING[17379]: chan_iax2.c:12470 build_peer: Set
peer->pokefreqnotok to 200

The existing code, below, correctly produces a warning if sscanf is unable
to convert the qualifyfreqnotok value to a number of milliseconds. 
However, whenever there is NO ERROR, the code produces a warning.  There is
no similar warning on other parameter assignments.  This one is confusing,
spurious, and should be removed or at least changed to a DEBUG.

... if (!strcasecmp(v->name, "qualifyfreqnotok")) {
        if (sscanf(v->value, "%30d", &peer->pokefreqnotok) != 1) {
            ast_log(LOG_WARNING, "Qualification testing frequency of peer
'%s' when NOT OK should be a number of milliseconds at line %d \
of iax.conf\n", peer->name, v->lineno);
        } else ast_log(LOG_WARNING, "Set peer->pokefreqnotok to %d\n",
peer->pokefreqnotok);

A patch is provided which simply removes the message.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-12-28 17:38 jcovert        New Issue                                    
2010-12-28 17:38 jcovert        Asterisk Version          => 1.8.1.1         
2010-12-28 17:38 jcovert        Regression                => No              
2010-12-28 17:38 jcovert        SVN Branch (only for SVN checkouts, not tarball
releases) => N/A             
======================================================================