[asterisk-bugs] [Asterisk 0018509]: [patch] Sending out unnecessary PROCEEDING messages breaks overlap dialing

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18509 
====================================================================== 
Reported By:                wimpy
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18509
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-12-21 02:30 CST
Last Modified:              2010-12-21 16:17 CST
====================================================================== 
Summary:                    [patch] Sending out unnecessary PROCEEDING messages
breaks overlap dialing
Description: 
chan_dahdi sends out a PROCEEDING message as soon as a call has a match in
the dialplan.
I think sending this message is unnecessary and can be harmful.
I think it should only be sent when Dial() is called with a definitive
destination.

So far I thought chan_dahdi was unable to do outgoing overlap dialing, but
I just found out that it does, but sabotages itself.

If you have an
exten => _N!,1,Dial(dahdi/g1/${EXTEN})
and use overlap dialing, the trouble is that you get a PROCEEDING after
you dialed the first digit which will tell the phone that dialing has
finished.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016789 [patch] Overlap receiving timeout, plus...
====================================================================== 

---------------------------------------------------------------------- 
 (0129853) rmudgett (administrator) - 2010-12-21 16:17
 https://issues.asterisk.org/view.php?id=18509#c129853 
---------------------------------------------------------------------- 
The '!' dialplan matching character seems to have some inconsistency in its
matching definition for the matching functions.  The
ast_matchmore_extension() is treating the '!' as the end of a pattern and
not considering that it is a zero or more match.

If the dialplan were instead changed to something like:
ignorepat => 9
exten => _9.,1,Dial(DAHDI/g1/${EXTEN:1})

And Alec's patch is used, it works. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-12-21 16:17 rmudgett       Note Added: 0129853                          
======================================================================