[asterisk-bugs] [Asterisk 0018501]: [patch] minivm: when sending mail and using volgain

[Asterisk Bug Tracker]

The following issue has been UPDATED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18501 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18501
Category:                   Applications/app_minivm
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 299001 
Request Review:              
====================================================================== 
Date Submitted:             2010-12-20 05:49 CST
Last Modified:              2010-12-20 09:23 CST
====================================================================== 
Summary:                    [patch] minivm: when sending mail and using volgain
Description: 
There's some questionable code in apps/app_minivm.c:sendmail() at around
line 1270 looks odd:

1. tmpfd is opened, but never closed.
2. finalfilename is points to part of the stack that gets de-allocated
soon.

Not sure if it causes a crash, as I ran into a different crash issue on
the same area. A demo patch is attached anyway.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-12-20 09:23 lmadsen        Description Updated                          
======================================================================