[asterisk-bugs] [Asterisk 0018279]: [patch] res_odbc using ^ separator in M(macro) option as argument separator in Dial app gives control characters

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18279 
====================================================================== 
Reported By:                zerohalo
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18279
Category:                   Resources/res_config_odbc
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     ready for review
Target Version:             1.4.37
Asterisk Version:           1.4.37-rc1 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-11-08 17:14 CST
Last Modified:              2010-12-16 03:03 CST
====================================================================== 
Summary:                    [patch] res_odbc using ^ separator in M(macro)
option as argument separator in Dial app gives control characters
Description: 
I believe I've seen this in the tracker before, but can't find it - feel
free to close this and redirect me.

in dialplan:

exten => s,1,Dial(${INTERFACE},${RINGTIME},rM(setmoh^accmusic))

the ^ seems to become an escape that mangles the argument (in this case,
the moh class):

[2010-11-07 08:03:08] WARNING[13261] app_macro.c: No such context
'macro-setmoh¬cmusic' for macro 'setmoh¬cmusic'

this does not appear to happen using res_config_mysql.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018251 [patch] Realtime field 'fullcontact' po...
====================================================================== 

---------------------------------------------------------------------- 
 (0129650) svnbot (reporter) - 2010-12-16 03:03
 https://issues.asterisk.org/view.php?id=18279#c129650 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 298480

U   branches/1.4/res/res_config_odbc.c

------------------------------------------------------------------------
r298480 | tilghman | 2010-12-16 03:03:41 -0600 (Thu, 16 Dec 2010) | 14
lines

Only increment the pointer once per loop, otherwise we corrupt the value.

(closes issue https://issues.asterisk.org/view.php?id=18251)
 Reported by: bcnit
 Patches: 
       20101110__issue18251.diff.txt uploaded by tilghman (license 14)
 Tested by: trev, jthurman, elguero

(closes issue https://issues.asterisk.org/view.php?id=18279)
 Reported by: zerohalo
 Patches: 
       20101109__issue18279.diff.txt uploaded by tilghman (license 14)
 Tested by: zerohalo

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=298480 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-12-16 03:03 svnbot         Checkin                                      
2010-12-16 03:03 svnbot         Note Added: 0129650                          
======================================================================