[asterisk-bugs] [Asterisk 0018091]: [patch] dialgroup fills database with duplicates

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18091 
====================================================================== 
Reported By:                bunny
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   18091
Category:                   Functions/func_dialgroup
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.2.11 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-10-04 20:37 CDT
Last Modified:              2010-12-16 02:57 CST
====================================================================== 
Summary:                    [patch] dialgroup fills database with duplicates
Description: 
every time a dialgroup is called, it appends to the astdb resulting in a
ridiculous number of repeats. It is, however, sorting the duplicates.

example usage:
http://www.asterisk.org/docs/asterisk/trunk/functions/dialgroup
http://www.voip-info.org/wiki/view/Asterisk+func+dialgroup

Either the way to use dialgroup is violently wrong or there is a bug in
how stuff works.

After a while, you end up with:

/dialgroup/5f                                     :
SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
...
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-512.office
&SIP/500 at phone-513.office&SIP/500 at phone-512.office&SIP/500 at phon...


database deltree dialgroup/5f also lies about its success.

====================================================================== 

---------------------------------------------------------------------- 
 (0129648) svnbot (reporter) - 2010-12-16 02:57
 https://issues.asterisk.org/view.php?id=18091#c129648 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 298479

_U  trunk/
U   trunk/funcs/func_dialgroup.c

------------------------------------------------------------------------
r298479 | tilghman | 2010-12-16 02:57:00 -0600 (Thu, 16 Dec 2010) | 22
lines

Merged revisions 298478 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r298478 | tilghman | 2010-12-16 02:56:13 -0600 (Thu, 16 Dec 2010) | 15
lines
  
  Merged revisions 298477 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2
  
  ........
    r298477 | tilghman | 2010-12-16 02:54:23 -0600 (Thu, 16 Dec 2010) | 8
lines
    
    Eliminate duplicates from container.
    
    (closes issue https://issues.asterisk.org/view.php?id=18091)
     Reported by: bunny
     Patches: 
           20101006__issue18091.diff.txt uploaded by tilghman (license 14)
     Tested by: bunny
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=298479 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-12-16 02:57 svnbot         Checkin                                      
2010-12-16 02:57 svnbot         Note Added: 0129648                          
======================================================================