[asterisk-bugs] [Asterisk 0018189]: RFC2833 DTMF generation broken due to SSRC change on bridges channels

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18189 
====================================================================== 
Reported By:                marcbou
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   18189
Category:                   Core/RTP
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     closed
Target Version:             1.8.1
Asterisk Version:           1.8.0 
JIRA:                       SWP-2473 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-10-22 12:13 CDT
Last Modified:              2010-12-07 17:00 CST
====================================================================== 
Summary:                    RFC2833 DTMF generation broken due to SSRC change on
bridges channels
Description: 
Since upgrading to the latest 1.8.0-rc, DTMF digits sent over SIP/RTP to
our service provider were no longer being detected.

We analyzed packet dumps, comparing old and new RTP packets being
generated by asterisk.

The difference was tracked down to asterisk 1.8.0-rc now changing the SSRC
value for RFC2833 DTMF digit packets.

If in main/channel.c:ast_channel_bridge() I comment out 

    ast_indicate(c0, AST_CONTROL_SRCCHANGE);
    ast_indicate(c1, AST_CONTROL_SRCCHANGE);

the SSRC no longer changes for DTMF digits and the provider can detect
them again.

However I am not sure if the change doesn't adversely affect other things.
Please advise.

Kind regards,

Marc Boucher



======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018352 SSRC is changing when DTMF sent
====================================================================== 

---------------------------------------------------------------------- 
 (0129448) svnbot (reporter) - 2010-12-07 17:00
 https://issues.asterisk.org/view.php?id=18189#c129448 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 297826

_U  trunk/
U   trunk/main/channel.c

------------------------------------------------------------------------
r297826 | jpeeler | 2010-12-07 17:00:42 -0600 (Tue, 07 Dec 2010) | 33
lines

Merged revisions 297825 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r297825 | jpeeler | 2010-12-07 16:59:30 -0600 (Tue, 07 Dec 2010) | 26
lines
  
  Merged revisions 297824 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2
  
  ................
    r297824 | jpeeler | 2010-12-07 16:58:54 -0600 (Tue, 07 Dec 2010) | 19
lines
    
    Merged revisions 297823 via svnmerge from 
    https://origsvn.digium.com/svn/asterisk/branches/1.4
    
    ........
      r297823 | jpeeler | 2010-12-07 16:57:48 -0600 (Tue, 07 Dec 2010) |
12 lines
      
      Revert code that changed SSRC for DTMF.
      
      Some previous behavior was attempted to be restored, but mistakingly
I did
      not realize that the previous behavior was incorrect. This fixes
DTMF not
      being detected since DTMF shouldn't cause the SSRC to change.
      
      (related to issue https://issues.asterisk.org/view.php?id=17404)
      (closes issue https://issues.asterisk.org/view.php?id=18189)
      (closes issue https://issues.asterisk.org/view.php?id=18352)
      Reported by: marcbou
      Tested by: cmbaker82
    ........
  ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=297826 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-12-07 17:00 svnbot         Checkin                                      
2010-12-07 17:00 svnbot         Note Added: 0129448                          
======================================================================