[asterisk-bugs] [DAHDI-linux 0018422]: [patch] dahdi-base locks channel-exporting module in kernel if channel open fails
Asterisk Bug Tracker
noreply at bugs.digium.com
Tue Dec 7 08:20:39 CST 2010
A NOTE has been added to this issue.
======================================================================
https://issues.asterisk.org/view.php?id=18422
======================================================================
Reported By: avarvit
Assigned To:
======================================================================
Project: DAHDI-linux
Issue ID: 18422
Category: dahdi (the module)
Reproducibility: always
Severity: major
Priority: normal
Status: acknowledged
JIRA:
Reviewboard Link:
======================================================================
Date Submitted: 2010-12-03 23:21 CST
Last Modified: 2010-12-07 08:20 CST
======================================================================
Summary: [patch] dahdi-base locks channel-exporting module in
kernel if channel open fails
Description:
If chan->span->ops->open() fails, then DAHDI_FLAGBIT_OPEN never
gets set and module_put is never called on the exporter module.
======================================================================
----------------------------------------------------------------------
(0129387) svnbot (reporter) - 2010-12-07 08:20
https://issues.asterisk.org/view.php?id=18422#c129387
----------------------------------------------------------------------
Repository: dahdi
Revision: 9510
U linux/trunk/drivers/dahdi/dahdi-base.c
------------------------------------------------------------------------
r9510 | sruffell | 2010-12-07 08:20:39 -0600 (Tue, 07 Dec 2010) | 13 lines
dahdi: Prevent unloadable module on failed open.
If chan->span->ops->open() fails then the reference count of the module
implementing the board driver will not be decremented. The result is a
module that would always be "in use" and unloadable.
This change makes sure to release that reference when open failed.
(closes issue https://issues.asterisk.org/view.php?id=18422)
Reported by: avarvit
Signed-off-by: Shaun Ruffell <sruffell at digium.com>
Acked-by: Angelos Varvitsiotis <avarvit at admin.grnet.gr>
------------------------------------------------------------------------
http://svn.digium.com/view/dahdi?view=rev&revision=9510
Issue History
Date Modified Username Field Change
======================================================================
2010-12-07 08:20 svnbot Checkin
2010-12-07 08:20 svnbot Note Added: 0129387
======================================================================
More information about the asterisk-bugs
mailing list