[asterisk-bugs] [Asterisk 0018309]: [patch] Core dumped after bridged call is hungup when mysql cdr backend is not available

[Asterisk Bug Tracker]

The following issue has been UPDATED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18309 
====================================================================== 
Reported By:                schmidts
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18309
Category:                   Addons/cdr_addon_mysql
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.8.0 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-11-15 08:27 CST
Last Modified:              2010-12-06 15:04 CST
====================================================================== 
Summary:                    [patch] Core dumped after bridged call is hungup
when mysql cdr backend is not available
Description: 
This only happens with cdr_mysql configured but not reachable (db is gone).
In Row 3578 in main/features.c the if cause a core dump. when i change the
order of checks (new_chan_cdr && new_peer_cdr in front before the test
flags) this dump doesnt occurs.

the attached patch solves the issue for me but i am not sure if this
really solves the problem.

i have found a strange part of code at main/features.c row: 3576 which
looks like its in there since rev 166665.
i know this is proper type of c code to keep the livetime of vars short.
But this part of code is at the end of the function and its allways called
so this extra { } is useless. For better reading we should remove this { }.

====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-12-06 15:04 lmadsen        Description Updated                          
======================================================================