[asterisk-bugs] [DAHDI-linux 0018422]: [patch] dahdi-base locks channel-exporting module in kernel if channel open fails

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18422 
====================================================================== 
Reported By:                avarvit
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   18422
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2010-12-03 23:21 CST
Last Modified:              2010-12-05 23:16 CST
====================================================================== 
Summary:                    [patch] dahdi-base locks channel-exporting module in
kernel if channel open fails
Description: 
If chan->span->ops->open() fails, then DAHDI_FLAGBIT_OPEN never
gets set and module_put is never called on the exporter module.


====================================================================== 

---------------------------------------------------------------------- 
 (0129319) avarvit (reporter) - 2010-12-05 23:16
 https://issues.asterisk.org/view.php?id=18422#c129319 
---------------------------------------------------------------------- 
OK then, I guess the following fix instructions do not fall
under any reasonable definition of "code", so you will not
have to kill it (now three times in a row): the suggested fix
is, around line 2714, check the return value from the open
function; if that value is non-zero, then invoke module_put,
because in that execution path module_put is not called
anywhere else and thus the caller module remains locked in
the kernel. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-12-05 23:16 avarvit        Note Added: 0129319                          
======================================================================