[asterisk-bugs] [Asterisk 0018252]: Newstate event contains CallerIDName/CallerIDNum of queue member

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18252 
====================================================================== 
Reported By:                gje
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18252
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.8.0 
JIRA:                       SWP-2563 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-11-04 11:07 CDT
Last Modified:              2010-12-03 16:04 CST
====================================================================== 
Summary:                    Newstate event contains CallerIDName/CallerIDNum of
queue member
Description: 
The Newstate event message contains different information with regarding to
asterisk 1.4 and 1.8.

The CallerIDName/CallerIDNum (ast 1.8) contains the caller info of the
queue member.
The CallerIDName/CallerID (ast 1.4) contains the caller info of the person
which is in the queue.

The CallerIDName/Num is showed correctly (MR X <12345>) on the display of
phone of the queue member.
 
====================================================================== 

---------------------------------------------------------------------- 
 (0129305) Bernard Merindol (reporter) - 2010-12-03 16:04
 https://issues.asterisk.org/view.php?id=18252#c129305 
---------------------------------------------------------------------- 
The problem is in ring_entry function:
In 1.6 we have:

 if (tmp->chan->cid.cid_num)
 ast_free(tmp->chan->cid.cid_num);
  tmp->chan->cid.cid_num = ast_strdup(qe->chan->cid.cid_num);
...

In 1.8

if (!tmp->chan->caller.id.number.valid) {
                if (qe->chan->connected.id.number.valid) {
                        struct ast_party_caller caller;


The test is the oposit. If change just with

if (tmp->chan->caller.id.number.valid) {

The event return good. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-12-03 16:04 Bernard MerindolNote Added: 0129305                          
======================================================================