[asterisk-bugs] [Asterisk 0018397]: IAX2 CODEC_PRES wrong (offset error?)

[Asterisk Bug Tracker]

The following issue has been RESOLVED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18397 
====================================================================== 
Reported By:                birgita
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   18397
Category:                   Channels/chan_iax2
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 296230 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-11-29 08:41 CST
Last Modified:              2010-12-01 10:59 CST
====================================================================== 
Summary:                    IAX2 CODEC_PRES wrong (offset error?)
Description: 
On an incoming IAX2 call, the console reports (correctly):

Tx-Frame Retry[000] -- OSeqno: 000 ISeqno: 000 Type: IAX     Subclass: NEW
   
   Timestamp: 00005ms  SCall: 09646  DCall: 00000 [94.12.29.127:2705]
   VERSION         : 2
   CODEC_PREFS     : (gsm|ulaw)
   FORMAT          : 2
   FORMAT2         : gsm
   CAPABILITY      : 6
   CAPABILITY2     : unknown
   ADSICPE         : 2

However, Asterisk sends over the wire as value for CODEC_PREFS: "CD"
This is incorrect. It should be "BC":

A = "AUDIO_G723",
B = "AUDIO_GSM",
C = "AUDIO_ULAW",
D = "AUDIO_ALAW",

In this case codec negotiation does not fail because of FORMAT(2).
====================================================================== 

---------------------------------------------------------------------- 
 (0129238) svnbot (reporter) - 2010-12-01 10:59
 https://issues.asterisk.org/view.php?id=18397#c129238 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 296990

U   branches/1.4/include/asterisk/frame.h

------------------------------------------------------------------------
r296990 | tilghman | 2010-12-01 10:59:27 -0600 (Wed, 01 Dec 2010) | 5
lines

Clarify documentation on how we store codec preference lists.

(closes issue https://issues.asterisk.org/view.php?id=18397)
 Reported by: birgita

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=296990 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-12-01 10:59 svnbot         Note Added: 0129238                          
2010-12-01 10:59 svnbot         Status                   new => assigned     
2010-12-01 10:59 svnbot         Assigned To               => tilghman        
2010-12-01 10:59 svnbot         Status                   assigned => resolved
2010-12-01 10:59 svnbot         Resolution               open => fixed       
======================================================================