[asterisk-bugs] [Asterisk 0015706]: [patch] app_festival hangs on reading from spawned subprocess

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15706 
====================================================================== 
Reported By:                modelnine
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   15706
Category:                   Applications/app_festival
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     ready for review
Target Version:             1.6.2.13
Asterisk Version:           SVN 
JIRA:                       SWP-1146 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-08-12 15:50 CDT
Last Modified:              2010-08-30 17:27 CDT
====================================================================== 
Summary:                    [patch] app_festival hangs on reading from spawned
subprocess
Description: 
Due to an invalid file descriptor (one that's already closed) being
referenced for writing in the subprocess that's spawned to feed the
festival output to the channel, app_festival blocks on trying to send voice
data to the connected channel. This kills the Asterisk session completely.

The attached patch fixes the issue and adds some debugging statements to
app_festival for checking that it now works.
====================================================================== 

---------------------------------------------------------------------- 
 (0126454) svnbot (reporter) - 2010-08-30 17:27
 https://issues.asterisk.org/view.php?id=15706#c126454 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 284280

U   branches/1.6.2/apps/app_festival.c

------------------------------------------------------------------------
r284280 | tilghman | 2010-08-30 17:27:07 -0500 (Mon, 30 Aug 2010) | 11
lines

Fix 3 coding errors:
  1) After we close FD, we should not be trying to write to it.
  2) Call _exit(0), not exit(0), to avoid running shutdown routines in a
child.
  3) Use endian, not processor, detection to ensure bytes are written in
the correct order.

(closes issue https://issues.asterisk.org/view.php?id=15706)
 Reported by: modelnine
 Patches: 
       asterisk-1.6.1.1-festival-debug.patch uploaded by modelnine
(license 865)
 Tested by: gmartinez

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=284280 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-30 17:27 svnbot         Note Added: 0126454                          
======================================================================