[asterisk-bugs] [Asterisk 0017862]: [patch] Manager interface requires a space after the :

Asterisk Bug Tracker noreply at bugs.digium.com
Sat Aug 28 16:29:49 CDT 2010


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17862 
====================================================================== 
Reported By:                cmoye
Assigned To:                lmadsen
====================================================================== 
Project:                    Asterisk
Issue ID:                   17862
Category:                   Core/ManagerInterface/NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for review
Target Version:             1.8.0
Asterisk Version:           1.8.0-beta3 
JIRA:                       SWP-2052 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.8 
SVN Revision (number only!): 282366 
Request Review:              
====================================================================== 
Date Submitted:             2010-08-14 11:57 CDT
Last Modified:              2010-08-28 16:29 CDT
====================================================================== 
Summary:                    [patch] Manager interface requires a space after the
:
Description: 
This patch lets the manager ignore spaces after the : when issuing
commands, and drops the requirement of a single space after the colon.

russell: Would you expect whitespace to be required after the header name
and colon in a manager action?  For example "Action: Ping" is fine. 
"Action:Ping" is not
lmadsen: russell: I'd expect to be liberal in what we accept (re: manager
Action:Ping)
russell: lmadsen: that's what I'm thinking, but that's now how AMI behaves
====================================================================== 

---------------------------------------------------------------------- 
 (0126421) svnbot (reporter) - 2010-08-28 16:29
 https://issues.asterisk.org/view.php?id=17862#c126421 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 284065

U   branches/1.8/main/manager.c

------------------------------------------------------------------------
r284065 | russell | 2010-08-28 16:29:46 -0500 (Sat, 28 Aug 2010) | 13
lines

Be more flexible with whitespace on AMI action headers.

Previously, this code required exactly one space to be after the ':' in
headers
for an AMI action.  This now makes whitespace optional, and allows
whitespace that
is there to vary in amount.

(closes issue https://issues.asterisk.org/view.php?id=17862)
Reported by: cmoye
Patches:
      manager.c.patch_trunk uploaded by cmoye (license 858)
      manager.c.patch_1.8 uploaded by cmoye (license 858)
Tested by: cmoye

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=284065 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-28 16:29 svnbot         Note Added: 0126421                          
======================================================================




More information about the asterisk-bugs mailing list