[asterisk-bugs] [Asterisk 0017878]: [patch] chan_sip fails to remove hold when receving a reINVITE without SDP

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17878 
====================================================================== 
Reported By:                frawd
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17878
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Target Version:             1.6.2.13
Asterisk Version:           1.6.2.11 
JIRA:                       SWP-2064 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-08-17 11:05 CDT
Last Modified:              2010-08-24 08:58 CDT
====================================================================== 
Summary:                    [patch] chan_sip fails to remove hold when receving
a reINVITE without SDP
Description: 
Patch for issue https://issues.asterisk.org/view.php?id=14448 never made it to
trunk so all versions above 1.4
suffer this problem.

Here is an updated patch for 1.6.2.11.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014448 [patch] chan_sip fails to remove hold w...
====================================================================== 

---------------------------------------------------------------------- 
 (0126265) davidw (reporter) - 2010-08-24 08:58
 https://issues.asterisk.org/view.php?id=17878#c126265 
---------------------------------------------------------------------- 
I've made an attempt to separate out our media direction attribute handling
changes, but:

- these are based on a patched 1.6.1.0; in particular it already contained
the patch that is the subject of this issue;
- I haven't verified that I've got all the relevant changes;
- I don't currently have the resources to forward port this to 1.6.2.
- It contains code to allow Asterisk to be active in initiating holds,
which should be considered a feature change, although I should have
eliminated all places where this could be triggered from the configuration
or environment.  Again I don't currently have the resources to decompose
the new feature from the bug fix part.
- one known flaw in the outgoing hold logic is that it doesn't set an
appropriate comment in the re-Invite, so it claims to be an external bridge
request. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-24 08:58 davidw         Note Added: 0126265                          
======================================================================