[asterisk-bugs] [Asterisk 0017878]: [patch] chan_sip fails to remove hold when receving a reINVITE without SDP

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17878 
====================================================================== 
Reported By:                frawd
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17878
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Target Version:             1.6.2.13
Asterisk Version:           1.6.2.11 
JIRA:                       SWP-2064 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-08-17 11:05 CDT
Last Modified:              2010-08-24 05:13 CDT
====================================================================== 
Summary:                    [patch] chan_sip fails to remove hold when receving
a reINVITE without SDP
Description: 
Patch for issue https://issues.asterisk.org/view.php?id=14448 never made it to
trunk so all versions above 1.4
suffer this problem.

Here is an updated patch for 1.6.2.11.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014448 [patch] chan_sip fails to remove hold w...
====================================================================== 

---------------------------------------------------------------------- 
 (0126255) davidw (reporter) - 2010-08-24 05:13
 https://issues.asterisk.org/view.php?id=17878#c126255 
---------------------------------------------------------------------- 
This area is a lot more messy than it may at first seem.  Re-invite without
SDP is not actually a request to remove hold, but rather a request for the
receiving side to start the negotiation.  Hold should only actually be
removed once both sides have exchanged SDP.

What the quote from the RFC is saying, is that the offer should not take
account of the fact that a hold exists.  However, it is only an offer, and
until the response is received (in the ACK) there has been no agreement to
remove the hold. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-24 05:13 davidw         Note Added: 0126255                          
======================================================================