[asterisk-bugs] [Asterisk 0017798]: Another sip_peer structure leak

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17798 
====================================================================== 
Reported By:                kkm
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   17798
Category:                   Channels/chan_sip/General
Reproducibility:            N/A
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
JIRA:                       SWP-2010 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-08-04 21:58 CDT
Last Modified:              2010-08-19 17:42 CDT
====================================================================== 
Summary:                    Another sip_peer structure leak
Description: 
I found a few places in chan_sip.c where multiple peers are removed by a 
call to ao2_t_callback(peers,..OBJ_UNLINK, ...). There is no 
corresponding attempt to removed them also from the peers_by_ip list:

In sip_prune_realtime() near line 15884
In reload_config() near line 26188
In sip_do_reload() near line 27747

Interesting that in another branch of sip_prune_realtime(), when a 
single peers is removed, it is unlinked from peers_by_ip.

Also, in build_peer() near line 25448, a single peer is removed from 
peers but not peers_by_ip().
====================================================================== 

---------------------------------------------------------------------- 
 (0126179) kkm (reporter) - 2010-08-19 17:42
 https://issues.asterisk.org/view.php?id=17798#c126179 
---------------------------------------------------------------------- 
There were no practical implications on asterisk performance or something
that I can positively test fixed; I only spotted that while eyeballing the
code when I was debugging a patch (for something not directly related).
When I asked on the dev list why are not object always removed from the
list by IP, Russel responded that it is probably a bug, asked me to open an
issue, and so I did. 

I'd be glad to be of more help here, but I do not really see what else can
I can do. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-19 17:42 kkm            Note Added: 0126179                          
======================================================================