[asterisk-bugs] [Asterisk 0016852]: [patch] Some issues with New SDP handling code and T.38

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16852 
====================================================================== 
Reported By:                cfc
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16852
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 247162 
Request Review:              
====================================================================== 
Date Submitted:             2010-02-17 08:36 CST
Last Modified:              2010-08-19 14:43 CDT
====================================================================== 
Summary:                    [patch] Some issues with New SDP handling code and
T.38
Description: 
- Connection information defined at media level are not read. If SDP don't
define a (c=) at session level, process_sdp() fail with "Insufficient
information in SDP (c=)...". The patch add processing of (c=) defined at
media level for image too.

- As process_sdp() now use a dedicated "isin" sockaddr_in,
sin.sin_addr.s_addr stay null in case of T38 re-invite. This force to hold
the channel. If MusicOnHold is present, generator is setup on the channel.
This result in dropping all udptl frames... The patch add a check on isin
to avoid unwanted Hold state.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
duplicate of        0016705 [patch] [regression] T.38 negotiation B...
====================================================================== 

---------------------------------------------------------------------- 
 (0126152) svnbot (reporter) - 2010-08-19 14:43
 https://issues.asterisk.org/view.php?id=16852#c126152 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 282859

U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r282859 | mnicholson | 2010-08-19 14:43:58 -0500 (Thu, 19 Aug 2010) | 23
lines

Merged revisions 277944 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r277944 | pabelanger | 2010-07-19 15:56:07 -0500 (Mon, 19 Jul 2010) | 16
lines
  
  Regression with T.38 negotiation
  
  Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
  of the reporter.  
  
  (issue https://issues.asterisk.org/view.php?id=16852)
  Reported by: cfc
  
  (closes issue https://issues.asterisk.org/view.php?id=16705)
  Reported by: mpiazzatnetbug
  Patches:
        issue16705_2.diff uploaded by ebroad (license 878)
  Tested by: vrban, ebroad, c0rnoTa, samdell3
  
  Review: https://reviewboard.asterisk.org/r/754/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282859 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-19 14:43 svnbot         Checkin                                      
2010-08-19 14:43 svnbot         Note Added: 0126152                          
======================================================================