[asterisk-bugs] [Asterisk 0017486]: [patch] response_refer() does not have a default case, so a 400 final response stalls in the Transfer() application

Wed Aug 18 08:11:37 CDT 2010

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17486 
====================================================================== 
Reported By:                davidw
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17486
Category:                   Channels/chan_sip/Transfers
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.6.2.12
Asterisk Version:           SVN 
JIRA:                       SWP-1667 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/837/ 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 269011 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-06-08 11:34 CDT
Last Modified:              2010-08-18 08:11 CDT
====================================================================== 
Summary:                    [patch] response_refer() does not have a default
case, so a 400 final response stalls in the Transfer() application
Description: 
For an outgoing refer request, generated by the Transfer() application,
chan_sip.c's response_refer routine only recognizes specific response
codes, which don't include "400 Bad Request", the generic 400 response
code.

As a result, if it gets an unrecognized final status, it does not wake up
the Transfer application to allow it to return a FAILURE response to the
dialplan.  

Cisco CCM 6 can generate this response to REFER, although not necessarily
to the REFERs generated by the standard Asterisk code.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012713 [patch] SIP Protocol Violation when REF...
====================================================================== 

---------------------------------------------------------------------- 
 (0126091) svnbot (reporter) - 2010-08-18 08:11
 https://issues.asterisk.org/view.php?id=17486#c126091 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 282640

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r282640 | mnicholson | 2010-08-18 08:11:36 -0500 (Wed, 18 Aug 2010) | 20
lines

Merged revisions 282639 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r282639 | mnicholson | 2010-08-18 08:10:39 -0500 (Wed, 18 Aug 2010) | 13
lines

  Properly handle 200 and unknown responses conatined in NOTIFY requests
received in response to REFER requests.

  This patch fixes the way asterisk handles NOTIFY requests received in
response to REFER requests.  These changes to NOTIFY handler were first
introduced in r217482.  This new change properly handles the 200 response
by queueing an AST_TRANSFER_SUCCESS control frame and also prevents that
control frame from being queued when provisional and unknown responses are
received.

  (issue https://issues.asterisk.org/view.php?id=17486)
  Reported by: davidw
  Tested by: mnicholson

  (issue https://issues.asterisk.org/view.php?id=12713)
  Reported by: davidw

  Review: https://reviewboard.asterisk.org/r/860/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282640 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-18 08:11 svnbot         Checkin                                      
2010-08-18 08:11 svnbot         Note Added: 0126091                          
======================================================================