[asterisk-bugs] [Asterisk 0017633]: [patch] (Regression) Pickup from Grandstream BLF button ignores the context specified in Pickup command

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17633 
====================================================================== 
Reported By:                urosh
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   17633
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Target Version:             1.6.2.12
Asterisk Version:           SVN 
JIRA:                       SWP-1852 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-07-13 05:22 CDT
Last Modified:              2010-08-13 13:55 CDT
====================================================================== 
Summary:                    [patch] (Regression) Pickup from Grandstream BLF
button ignores the context specified in Pickup command
Description: 
Hi i had problem described in this issue: 
https://issues.asterisk.org/view.php?id=17120
asterisk error was:

[Mar 30 09:48:26] NOTICE[30223]: chan_sip.c:19860 handle_request_invite:
Trying to pick up 520 at blf
[Mar 30 09:48:27] NOTICE[30223]: chan_sip.c:19860 handle_request_invite:
Trying to pick up 520 at blf
[Mar 30 09:48:27] NOTICE[30223]: app_directed_pickup.c:257 pickup_exec: No
target channel found for 520.

I managed to correct it with removing p->callid in line 11302.
I am not a programmer of c++ so I am attaching corrected lines, that
worked for me.

Now phone works like in version 1.6.1, where phone on blinking BLF called
**EXTEN.


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014567 Directed call pickup does not work usin...
related to          0017671 Fetching Call with Grandstream-BLF (**$...
related to          0017120 (Regression) Pickup from Grandstream BL...
====================================================================== 

---------------------------------------------------------------------- 
 (0125949) svnbot (reporter) - 2010-08-13 13:55
 https://issues.asterisk.org/view.php?id=17633#c125949 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 282235

U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r282235 | dvossel | 2010-08-13 13:54:59 -0500 (Fri, 13 Aug 2010) | 16
lines

only do magic pickup when notifycid is enabled

A new way of doing BLF pickup was introduced into 1.6.2.  This feature
adds a call-id value into the XML of a SIP_NOTIFY message sent to alert
a subscriber that a device is ringing.  This option should only be enabled
when the new 'notifycid' option is set... but this was not the case. 
Instead
the call-id value was included for every RINGING Notify message, which
caused a regression for people who used other methods for call pickup.

(closes issue https://issues.asterisk.org/view.php?id=17633)
Reported by: urosh
Patches:
      chan_sip.txt uploaded by urosh (license )
      blf_cid_issue.diff uploaded by dvossel (license 671)
Tested by: dvossel, urosh, okrief, alecdavis

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282235 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-13 13:55 svnbot         Note Added: 0125949                          
======================================================================