[asterisk-bugs] [Asterisk 0017007]: [patch] RTP Timestamp changes after transfer, but SSRC not and the markerbit ist not set.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17007 
====================================================================== 
Reported By:                addix
Assigned To:                twilson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17007
Category:                   Channels/chan_sip/Transfers
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Target Version:             1.6.2.12
Asterisk Version:           SVN 
JIRA:                       SWP-1096 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-03-11 10:07 CST
Last Modified:              2010-08-13 11:44 CDT
====================================================================== 
Summary:                    [patch] RTP Timestamp changes after transfer, but
SSRC not and the markerbit ist not set.
Description: 
On every SIP Transfer (Example: A calls B / B places A on hold / B calls C
/ A sends Transfer to Asterisk PBX) the Outing RTP Traffic from Asterisk to
the transfer target (RTP to C) is broken. The Asterisk is changing the RTP
Timestamp massivly but the SSRC stays on the old value and the timestamp
marker is also not set. As soon as the new timestamp is smaller than the
old timestamp value the transfer target rejects the RTP Packets after the
transfer (Not really, it's just not played), so i get one way audio.

I experienced that with serveral local SIP-Carriers and Funkwerk Rxxxx
BRI/PRI Mediagateways as transfer target.

Due to my limited Asterisk-Source knowledge i'am not sure that my attached
patch is the correct solution for this problem. After applying my patch the
problem seems to be solved. The Asterisk is changing the SSRC & setting the
Markerbit after the transfer for the RTP-Traffic to the transfer target.




======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017404 [patch] [regression] audio delay when b...
====================================================================== 

---------------------------------------------------------------------- 
 (0125946) twilson (administrator) - 2010-08-13 11:44
 https://issues.asterisk.org/view.php?id=17007#c125946 
---------------------------------------------------------------------- 
addix: I reworked the patch to address the suggestions I made. I removed
the lock/unlock and check for original because in 1.4 original should be
locked before calling ast_do_masquerade() and therefor has to be both there
and locked. I added the if ((bridged = ast_bridged_channel(original)))
because ast_bridged_channel will look for the "bridged_channel" callback
function on channels like the agent channel, so that if we have an Agent
that is really a SIP channel, we'll send the indication to the SIP channel
which understands the SRCCHANGE indication, instead of the Agent channel
which doesn't.

If you wouldn't mind testing to make sure that I didn't inadvertently
break something, I'd appreciate it. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-13 11:44 twilson        Note Added: 0125946                          
======================================================================