[asterisk-bugs] [Asterisk 0017824]: [regression] After 1.6.2.8 the #include directive does not work if missing closing double quote

Asterisk Bug Tracker noreply at bugs.digium.com
Thu Aug 12 14:54:25 CDT 2010


The following issue requires your FEEDBACK. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17824 
====================================================================== 
Reported By:                Micc
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17824
Category:                   Core/Configuration
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.2.10 
JIRA:                       SWP-2029 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-08-10 00:19 CDT
Last Modified:              2010-08-12 14:54 CDT
====================================================================== 
Summary:                    [regression] After 1.6.2.8 the #include directive
does not work if missing closing double quote
Description: 
As soon as I started 1.6.2.10 I noticed my dialplan reload was not a valid
command and a fraction of my dialplan existed. Dialplan show ? only showed
some of the contexts in my extensions.conf. I use a lot of includes and I
have a lot of lines that are commented out spacers of dashes and
underscores like
;--------------------------------------------------------------------
#include "mydir/macros.conf"
;____________________________________________________________________

I also have a lot of nested include files. I had to down grade to 1.6.2.8
which worked fine with the same files. I tried a second time with a fresh
1.6.2.10 source tree with the same results.
====================================================================== 

---------------------------------------------------------------------- 
 (0125914) lmadsen (administrator) - 2010-08-12 14:54
 https://issues.asterisk.org/view.php?id=17824#c125914 
---------------------------------------------------------------------- 
I think the way to really fix this is to add a WARNING message that says
there is a missing closing quote, but jtodd does not think "fixing" this by
having the behaviour that you don't need a closing quote is correct. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-12 14:54 lmadsen        Note Added: 0125914                          
2010-08-12 14:54 lmadsen        Status                   acknowledged =>
feedback
======================================================================




More information about the asterisk-bugs mailing list