[asterisk-bugs] [Asterisk 0017824]: Problem loading includes in 1.6.2.10

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17824 
====================================================================== 
Reported By:                Micc
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17824
Category:                   Core/Configuration
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.2.10 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-08-10 00:19 CDT
Last Modified:              2010-08-10 20:11 CDT
====================================================================== 
Summary:                    Problem loading includes in 1.6.2.10
Description: 
As soon as I started 1.6.2.10 I noticed my dialplan reload was not a valid
command and a fraction of my dialplan existed. Dialplan show ? only showed
some of the contexts in my extensions.conf. I use a lot of includes and I
have a lot of lines that are commented out spacers of dashes and
underscores like
;--------------------------------------------------------------------
#include "mydir/macros.conf"
;____________________________________________________________________

I also have a lot of nested include files. I had to down grade to 1.6.2.8
which worked fine with the same files. I tried a second time with a fresh
1.6.2.10 source tree with the same results.
====================================================================== 

---------------------------------------------------------------------- 
 (0125786) Micc (reporter) - 2010-08-10 20:11
 https://issues.asterisk.org/view.php?id=17824#c125786 
---------------------------------------------------------------------- 
I'd like some feedback on whether it would be better to be strict here or
let id behave the same as previous versions so people's dialplans don't go
to hell when they upgrade. I'm glad it was strict in one sense, that I was
able to fix it, but if a call had came in during that time I would have
lost a call, and lucky I had a 1.6.2.8 already built and ready for a make
install to roll back to.

I think the best of both worlds is to allow it to load the file, but log
an error saying that the include line is missing the ending quote. This log
message would go in the new else block. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-10 20:11 Micc           Note Added: 0125786                          
======================================================================