[asterisk-bugs] [Asterisk 0017044]: [regression][patch] SDP c and o lines contain the wrong IP address when using an externally mapped IP(extern{ip, host})

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17044 
====================================================================== 
Reported By:                ebroad
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   17044
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/566/ 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-03-16 15:45 CDT
Last Modified:              2010-08-10 11:55 CDT
====================================================================== 
Summary:                    [regression][patch] SDP c and o lines contain the
wrong IP address when using an externally mapped IP(extern{ip,host})
Description: 
The problem stems from a call to ast_rtp_instance_get_local_address() in
chan_sip.c in get_our_media_address(). ast_rtp_instance_get_local_address()
will always return the internal IP address of the Asterisk machine, which
could pose a problem when using NAT. 

A simple solution would be to override {v,t}sin->sin_addr in
get_our_media_address() with p->ourip.sin_addr.s_addr if it is different,
though I don't know what that might break.  
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013823 [patch] Response to REGISTER is sent to...
====================================================================== 

---------------------------------------------------------------------- 
 (0125762) svnbot (reporter) - 2010-08-10 11:55
 https://issues.asterisk.org/view.php?id=17044#c125762 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 281533

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r281533 | russell | 2010-08-10 11:55:49 -0500 (Tue, 10 Aug 2010) | 15
lines

Merged revisions 281532 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r281532 | russell | 2010-08-10 11:54:20 -0500 (Tue, 10 Aug 2010) | 8
lines
  
  Ensure that the proper external address is used for the RTP destination.
  
  (closes issue https://issues.asterisk.org/view.php?id=17044)
  Reported by: ebroad
  Tested by: ebroad
  
  Review: https://reviewboard.asterisk.org/r/566/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=281533 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-10 11:55 svnbot         Checkin                                      
2010-08-10 11:55 svnbot         Note Added: 0125762                          
======================================================================