[asterisk-bugs] [Asterisk 0017824]: Problem loading includes in 1.6.2.10

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17824 
====================================================================== 
Reported By:                Micc
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17824
Category:                   Core/Configuration
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.2.10 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-08-10 00:19 CDT
Last Modified:              2010-08-10 01:03 CDT
====================================================================== 
Summary:                    Problem loading includes in 1.6.2.10
Description: 
As soon as I started 1.6.2.10 I noticed my dialplan reload was not a valid
command and a fraction of my dialplan existed. Dialplan show ? only showed
some of the contexts in my extensions.conf. I use a lot of includes and I
have a lot of lines that are commented out spacers of dashes and
underscores like
;--------------------------------------------------------------------
#include "mydir/macros.conf"
;____________________________________________________________________

I also have a lot of nested include files. I had to down grade to 1.6.2.8
which worked fine with the same files. I tried a second time with a fresh
1.6.2.10 source tree with the same results.
====================================================================== 

---------------------------------------------------------------------- 
 (0125744) Micc (reporter) - 2010-08-10 01:03
 https://issues.asterisk.org/view.php?id=17824#c125744 
---------------------------------------------------------------------- 
Ok, so the problem was a malformed #include "without/an/endquote
So in previous versions of asterisk it was forgiving of not having the end
quote, but the new code requires it or it thinks the whole thing is the
file name. This could really screw over some people if they upgrade and
have the same problem. So if you want to make it forgiving like previous
versions you can do this on line 1066
-                         }
+                         } else {
+                                cur++; // be forgiving as previous
versions.
+                         }


Its right after this code:
                        if (*(c + strlen(c) - 1) == quote_char) {
                                cur++;
                                *(c + strlen(c) - 1) = '\0';
                        }

Sorry for it not being an official patch. I haven't done one of those
before. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-08-10 01:03 Micc           Note Added: 0125744                          
======================================================================