[asterisk-bugs] [Asterisk 0016196]: Core dump in audio_audiohook_write_list

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16196 
====================================================================== 
Reported By:                atis
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   16196
Category:                   Core/General
Reproducibility:            sometimes
Severity:                   block
Priority:                   normal
Status:                     assigned
Target Version:             1.4.31
Asterisk Version:           SVN 
JIRA:                       SWP-1302 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/623/ 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 228147 
Request Review:              
====================================================================== 
Date Submitted:             2009-11-06 08:47 CST
Last Modified:              2010-04-29 10:52 CDT
====================================================================== 
Summary:                    Core dump in audio_audiohook_write_list
Description: 
This crash was introduced somewhere between 1.6.1.6 and r228147. I can
reproduce it quite easily while running automated tests.

# 0  0x0000000000446613 in audio_audiohook_write_list
(chan=0x2aaac415ae68, audiohook_list=0x2aaaac2a0728,
direction=AST_AUDIOHOOK_DIRECTION_WRITE, frame=0x2aaaac455658) at
/usr/dist/asterisk-svn-1.6.1-latest-vanilla/include/asterisk/util
s.h:270
# 1  0x0000000000446a7e in ast_audiohook_write_list (chan=0x2aaac415ae68,
audiohook_list=0x2aaaac2a0728, direction=AST_AUDIOHOOK_DIRECTION_WRITE,
frame=0x2aaaac455658) at audiohook.c:704
# 2  0x00000000004608d5 in ast_write (chan=0x2aaac415ae68, fr=0x2411e40)
at channel.c:3472
# 3  0x0000000000466055 in ast_generic_bridge (c0=0x2aaac4359818,
c1=0x2aaac415ae68, config=0x429a07b0, fo=0x4299eb38, rc=0x4299eb30,
bridge_end={tv_sec = 0, tv_usec = 0}) at channel.c:4855
# 4  0x0000000000467e9e in ast_channel_bridge (c0=0x2aaac4359818,
c1=0x2aaac415ae68, config=0x429a07b0, fo=0x4299eb38, rc=0x4299eb30) at
channel.c:5194
# 5  0x000000000049cfeb in ast_bridge_call (chan=0x2aaac4359818,
peer=0x2aaac415ae68, config=0x429a07b0) at features.c:2544
# 6  0x00002aaabc84171f in try_calling (qe=0x429a0e60, options=0x429a0db7
"", announceoverride=0x429a0db9 "", url=0x429a0db8 "", tries=0x429a1084,
noption=0x429a1080, agi=0x0, macro=0x0, gosub=0x0, ringing=0) at
app_queue.c:4058
# 7  0x00002aaabc8459cd in queue_exec (chan=0x2aaac4359818,
data=0x429a12d0) at app_queue.c:4998

====================================================================== 

---------------------------------------------------------------------- 
 (0121163) svnbot (reporter) - 2010-04-29 10:52
 https://issues.asterisk.org/view.php?id=16196#c121163 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 260049

U   branches/1.4/include/asterisk/audiohook.h
U   branches/1.4/main/audiohook.c

------------------------------------------------------------------------
r260049 | dvossel | 2010-04-29 10:31:02 -0500 (Thu, 29 Apr 2010) | 17
lines

Fixes crash in audiohook_write_list

The middle_frame in the audiohook_write_list function was
being freed if a audiohook manipulator returned a failure.
This is incorrect logic.  This patch resolves this and
adds detailed descriptions of how this function should work
and why manipulator failures must be ignored.

(closes issue https://issues.asterisk.org/view.php?id=17052)
Reported by: dvossel
Tested by: dvossel

(closes issue https://issues.asterisk.org/view.php?id=16196)
Reported by: atis

Review: https://reviewboard.asterisk.org/r/623/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=260049 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-04-29 10:52 svnbot         Checkin                                      
2010-04-29 10:52 svnbot         Note Added: 0121163                          
======================================================================