[asterisk-bugs] [Asterisk 0017235]: [patch] asterisk dsp always reports detected DTMF length to be 0ms

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17235 
====================================================================== 
Reported By:                frawd
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17235
Category:                   Core/General
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.2.7-rc2 
JIRA:                       SWP-1337 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-04-23 10:21 CDT
Last Modified:              2010-04-28 13:29 CDT
====================================================================== 
Summary:                    [patch] asterisk dsp always reports detected DTMF
length to be 0ms
Description: 
The attached patch makes the DSP report the correct length for DTMF
detected in the audio.

Tested with DAHDI channels (FXS, FXO, ISDN PRI) and SIP channels
configured as "inband".
====================================================================== 

---------------------------------------------------------------------- 
 (0121082) dimas (reporter) - 2010-04-28 13:29
 https://issues.asterisk.org/view.php?id=17235#c121082 
---------------------------------------------------------------------- 
I think it is just coincidence that your patch fixes your problem. If
caller hangs up _immediately_ after sending the last digit, there is always
a good chance the last digit won't be properly relayed.  This is because
even DTMF BEGIN frame is delayed a bit by dsp.c - until it gets reliable
detection. So to me it looks like you should use some other approach to fix
your issue.

The only way to properly report the duration is to modify functions doing
digit detection so it will report not just digit but its start/end times as
well. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-04-28 13:29 dimas          Note Added: 0121082                          
======================================================================