[asterisk-bugs] [Asterisk 0017250]: [patch] Pretty Config Files

Asterisk Bug Tracker noreply at bugs.digium.com
Wed Apr 28 12:16:58 CDT 2010


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17250 
====================================================================== 
Reported By:                lathama
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17250
Category:                   General
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-04-27 10:48 CDT
Last Modified:              2010-04-28 12:16 CDT
====================================================================== 
Summary:                    [patch] Pretty Config Files
Description: 
As a feature here is a script that will clean up the config files.  This is
useful when users.conf and other files have been grown to large.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014509 [patch] users.conf (and other .conf fil...
====================================================================== 

---------------------------------------------------------------------- 
 (0121079) tzafrir (manager) - 2010-04-28 12:16
 https://issues.asterisk.org/view.php?id=17250#c121079 
---------------------------------------------------------------------- 
1. Please use /bin/sh
2. I wonder if it's possible to fix this issue in the code. Right now the
script is over-aggressive: modifying all config files even if there's no
need to. It will fail if you e.g. have a single read-only file there.

3. Furthermore, it would be slightly more effecient to have a single sed
command:

sed -i -e 's/foo/bar/g' -e 's/aaa/bbb/g' *.conf 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-04-28 12:16 tzafrir        Note Added: 0121079                          
======================================================================




More information about the asterisk-bugs mailing list